Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use GtkShortcutsWindow for Help tool.#11085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dstansby merged 1 commit intomatplotlib:masterfromQuLogic:helptool-gtk3
Apr 22, 2018

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedApr 19, 2018
edited
Loading

PR Summary

A followup to#11045, using GTK's builtin widgets for shortcuts, when they are available. I also applied a small hack of putting every shortcut in its own group, because then GTK automatically splits columns and pages.
screenshot from 2018-04-18 22-32-15

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogicQuLogic added this to thev3.0 milestoneApr 19, 2018
@jklymak
Copy link
Member

I guess its not this PR, but can the1/2/3/4... be changed to1-9 or something?

@QuLogic
Copy link
MemberAuthor

All the shortcuts are added to the widget and the/ and other formatting is added by GTK automatically. If you wanted to coalesce like that, it'd be an enhancement for the GTK widget, I think.

@dstansbydstansby merged commit41a81c0 intomatplotlib:masterApr 22, 2018
@QuLogicQuLogic deleted the helptool-gtk3 branchApril 22, 2018 18:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@jklymak@anntzer@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp