Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Update Pie Demo2#11083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Update Pie Demo2#11083
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Not a fan of the pie call indenting I’d either just indent 8 spaces or line up w the pie call, not the ax object. But I’m hardly a python indenting pro. |
dstansby approved these changesApr 19, 2018
jklymak added a commit that referenced this pull requestApr 19, 2018
Backport PR#11083 on branch v2.2.2-doc
dstansby added a commit that referenced this pull requestApr 23, 2018
dstansby added a commit that referenced this pull requestApr 23, 2018
jklymak added a commit that referenced this pull requestApr 23, 2018
…of-pr-11083Revert "Backport PR#11083 on branch v2.2.2-doc"
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Pie Demo2 rewritten. In particular
GridSpectoplt.subplots()- simpler in this case.pie does now set aspect=1. No need to do this explicitly anymoretextpropskwarg instead of looping over the returned textssetpinsead of looping over the autotexts.