NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Remove setup_tests_only.py.#11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:remove-setup_tests_only

Apr 16, 2018

Merged

Remove setup_tests_only.py.#11055

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:remove-setup_tests_only

Apr 16, 2018

Conversation

Copy link

Contributor

anntzer commentedApr 16, 2018

That file was added in42fa2b6 without comment as to why (and renamed inab99e65 to avoid confusing pytest); callingpython setup_test_only.py sdist (which I guess is the only reasonable thing to do with it -- it's distutils so you can't even build a wheel out of it) doesn't create a correct "tests-only" sdist either.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Remove setup_tests_only.py.

5c82032

That file was added in42fa2b6 without comment as to why (and renamed inab99e65 to avoid confusing pytest); calling `python setup_test_only.pysdist` (which I guess is the only reasonable thing to do with it -- it'sdistutils so you can't even build a wheel out of it) doesn't create acorrect "tests-only" sdist either.

anntzer added this to thev3.0 milestone

Apr 16, 2018