NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

FIX: image respect norm limits w/ None#11047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 3 commits intomatplotlib:masterfromjklymak:fix-image-respect-norm-limits

May 14, 2018

Merged

FIX: image respect norm limits w/ None#11047

tacaswell merged 3 commits intomatplotlib:masterfromjklymak:fix-image-respect-norm-limits

May 14, 2018

Conversation

Copy link

Member

jklymak commentedApr 13, 2018•
edited
Loading

PR Summary

Re-closes#10072

We are slowly suqishing the "big number" bugs in imshow.

This one was caused by only specifyingvmax but notvmin. Algorithm is the same as before, but ifvmin isNone, then we scale bya_min.

importmatplotlib.pyplotaspltimportnumpyasnpx=np.random.random([3,3])x[1,1]=1.e80plt.imshow(x,vmax=2)plt.show()

Before

After

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

FIX: image respect norm limits w/ None

ea8f80a

jklymak added this to thev2.2.3 milestone

Apr 13, 2018

jklymak requested a review fromtacaswell

April 13, 2018 16:50

jklymak mentioned this pull request

Apr 13, 2018

imshow doesn't properly display some images#10072

Closed

tacaswell reviewed

Apr 13, 2018

View reviewed changes

lib/matplotlib/image.py Outdated

		a_max = np.float64(newmax)
		if newmax is not None or newmin is not None:
		A_scaled = np.clip(A_scaled, newmin, newmax)
		vmin = self.norm.vmin if self.norm.vmin is not None else a_min

Copy link

Member

tacaswellApr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would doif self.norm.vmin is None or self.norm.vmax is None: self.norm.autoscale_None(A)

Copy link

MemberAuthor

jklymakApr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sure - its OK to modify the norm here?

Copy link

MemberAuthor

jklymakApr 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

don't even need the if-statement in that case.

FIX: image respect norm limits w/ None

89c3345

jklymak added the API: consistency label

Apr 13, 2018

jklymak force-pushed thefix-image-respect-norm-limits branch from9d17f6f to023ddb8Compare

April 13, 2018 19:53

Copy link

MemberAuthor

jklymak commentedApr 18, 2018

Ping@tacaswell

timhoffm approved these changes

May 5, 2018

View reviewed changes

Copy link

Member

timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please squash before merging.

jklymak force-pushed thefix-image-respect-norm-limits branch from023ddb8 to918c8a5Compare

May 6, 2018 15:28

Copy link

MemberAuthor

jklymak commentedMay 6, 2018

squashed and rebased....

jklymak closed this

May 6, 2018

jklymak reopened this

May 6, 2018

jklymak requested a review fromtacaswell

May 7, 2018 21:45

FIX: image respect norm limits w/ None

8d53a8a

jklymak force-pushed thefix-image-respect-norm-limits branch from918c8a5 to8d53a8aCompare

May 9, 2018 20:32

tacaswell merged commit59e550b intomatplotlib:master

May 14, 2018

Copy link

lumberbot-appbot commentedMay 14, 2018

There seem to be a conflict, please backport manually

lumberbot-appbot added the status: needs manual backport label

May 14, 2018

Copy link

Member

dstansby commentedMay 29, 2018

Does this want a backport to2.2.x?

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request

Aug 4, 2018

Merge pull requestmatplotlib#11047from jklymak/fix-image-respect-no…

faf9684

…rm-limitsFIX: image respect norm limits w/ NoneConflicts:lib/matplotlib/image.py          - keep changes backported from master.  Looks like conflict            was due to some white-space clean up done on master.