NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Run setupext qt checks in a subprocess rather than with multiprocessing.#10886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:setupext-qt

Closed

Run setupext qt checks in a subprocess rather than with multiprocessing.#10886

anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:setupext-qt

Conversation

Copy link

Contributor

PR Summary

(yes, having code as strings is a bit ugly, but less that having multiprocessing in setup.py...)

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added the Build label

Mar 27, 2018

anntzer force-pushed thesetupext-qt branch from03b7c5e to5c5a51eCompare

March 27, 2018 00:47

tacaswell added this to thev3.0 milestone

Mar 27, 2018

Copy link

Member

tacaswell commentedMar 27, 2018

Can you also remove themultiprocess import now?

Bit surprised that you can import both pyqt and pyside in one process.

Copy link

ContributorAuthor

#10885 needs to be merged too before removing multiprocessing (or I can rebase the later of the two PRs).
I think the impossibility of importing qt4 and qt5 in the same process is due to C symbol clash(?), so that's not a problem with pyqt and pyside(?).

Run setupext qt checks in a subprocess rather than with multiprocessing.

281814d

anntzer force-pushed thesetupext-qt branch from5c5a51e to281814dCompare

March 27, 2018 03:35

anntzer modified the milestones:v3.0,unassigned

Jul 16, 2018

Copy link

ContributorAuthor

anntzer commentedJul 16, 2018

This will basically become obsolete once#11600 or a variant thereof gets merged (we won't be checking for the GUI toolkits during the build at all anymore).
I guess#11600 (or variant) should get in soon so I'll remilestone this away from 3.0 for now; I'll close this once#11600 goes in (it's not a problem either if this gets merged if#11600 ends up taking too long).