Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

FIX: ioerror font cache, second try#10857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

jklymak
Copy link
Member

PR Summary

As per#9676 (review)#9676 didn't actually catch the font cache error (well, it caught it, but threw another error instead).

This should fix.@lmr, if you are able to test, that would be very helpful, because I can't actually trigger the error!

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

maxnoeand others added30 commitsFebruary 28, 2018 09:07
The `elif` clauses in `Marker.set_marker` needed to be reorderedbecause any Python object that has a `__len__` method is aninstance of `collections.Sized`.
remove trailing spaces on a comment line
make seaborn great again on Matplotlib-2.2
(Too many spaces between "layout." and "You", missing betwen "subplots"and "with".)
Fix extra and missing spaces in constrainedlayout warning.
Also reorder other mentioned 3rdparty packages to alphabetical order.
…boilerplate.pyRemove if six.PY2 code paths from boilerplate.py
Support markers from Paths that consist of one line segment
so don't rely on the 3rd party version.Also replace py.test by pytest in the docs (recommended since pytest3.0,https://docs.pytest.org/en/latest/changelog.html#id281; we requirepytest>=3.1 anyways).Also delete tox.ini which is clearly outdated.
Add a link from the examples to the user's guide.Clarify that the weakref behavior only affects *methods* used ascallbacks, not free functions.
…strainedlayoutFIX/ENH CL: Allow single parent colorbar w/ gridspec layout
Replace the Locked contextmanager (which locks a directory, preventingother (cooperative) processes to access it) by a private _lock_pathcontextmanager, which locks a single file (or directory).- The finer grained lock avoids locking out the entire tex cache when  handling usetex, which is useful when running multiple processes at  once.- Python3 implements the `"x"` ("exclusive") mode to open, which we can  use instead of relying on `makedirs` to achieve a race-free operation  on the filesystem.- The previous implementation allowed multiple threads of a single  process to acquire the same lock, but (for the use cases here, e.g.  running a tex subprocess) this is actually undesirable.  Removing this  behavior also simplifies the implementation.- As far as I can tell, the previous implementation was actually racy:  in    retries = 50    sleeptime = 0.1    while retries:        files = glob.glob(self.pattern)        if files and not files[0].endswith(self.end):            time.sleep(sleeptime)            retries -= 1        else:            break    else:        err_str = _lockstr.format(self.pattern)        raise self.TimeoutError(err_str)    # <----- HERE    if not files:        try:            os.makedirs(self.lock_path)        except OSError:            pass    else:  # PID lock already here --- someone else will remove it.        self.remove = False  multiple processes can reach "HERE" at the same time and each  successfully create their own lock.
anntzerand others added18 commitsMarch 17, 2018 21:05
This ensures that when a cairo-based backend is active, animations alsoget saved using backend_cairo, rather than falling back on backend_agg.
…stringDOC: make legend docstring interpolated
DOC: Update layout of sidebar in documentation
The Agg backend still doesn't know how to make use of that informationin draw_markers, but third-party backends (e.g. mplcairo) do honor thesetting.
Propagate marker antialias setting to GraphicsContext.
Add some basic smoketesting for webagg (and wx).
- Give the colorbars a reasonable aspect ratio.- Fix a link.- Other minor edits.
DOC: Make colorbar tutorial examples look like colorbars.
DOC: Don't use private attribute in tk example.  Fix Toolbar class rename.
@jklymakjklymak added this to thev2.2.3 milestoneMar 21, 2018
@jklymakjklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelMar 21, 2018
@jklymak
Copy link
MemberAuthor

jklymak commentedMar 21, 2018
edited
Loading

Note, no need to merge into master because this code no longer exists in master. Hopefully I did the PR correctly to go into 2.2.3

@anntzer
Copy link
Contributor

The code is still in master (line 912) so the fix should be applied there too.

@anntzeranntzer modified the milestones:v2.2.3,v3.0Mar 21, 2018
@jklymakjklymakforce-pushed thefix-ioerror-font-cache branch from2d4fb22 to5766c9fCompareMarch 21, 2018 17:01
@jklymakjklymak mentioned this pull requestMar 21, 2018
6 tasks
@jklymak
Copy link
MemberAuthor

Closed in lieue of#10858 so I could PR against master. Prob a way to do it w/o a new PR, but...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.status: duplicate
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

32 participants
@jklymak@anntzer@jflatow@tacaswell@tekknolagi@cclauss@QuLogic@maxnoe@timhoffm@lpsinger@efiring@stonebig@dstansby@dopplershift@phobson@jkseppan@lkjell@TD22057@jinshifen33@Osarumwense@salindersidhu@JelsB@gregorybchris@WeatherGod@swfiua@AlexCav@thuvejan@afvincent@dniku@br-Zhang@jenshnielsen@NQuibin

[8]ページ先頭

©2009-2025 Movatter.jp