Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Propagate marker antialias setting to GraphicsContext.#10833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The Agg backend still doesn't know how to make use of that informationin draw_markers, but third-party backends (e.g. mplcairo) do honor thesetting.
tacaswell approved these changesMar 18, 2018
timhoffm approved these changesMar 19, 2018
Does this solve#10825 ? If so, shouldn't the issue be closed? If not, what's left to solve it? |
Only with mplcairo... so the issue should stay open (now Agg gets the info, but Ithink (TBC?) it doesn't take advantage of it). |
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestAug 4, 2018
Propagate marker antialias setting to GraphicsContext.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agg backend still doesn't know how to make use of that information
in draw_markers, but third-party backends (e.g. mplcairo) do honor the
setting.
xref#10825.
PR Summary
PR Checklist