Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixed not being able to set vertical/horizontal alignments in polar graphs#10792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I believethis pull request is what caused this regression. |
pbregener commentedMar 23, 2018
Would love to see this simple patch backported to |
OD1995 commentedMar 27, 2018
@charlesruan@pbregener is this fix live? If so, how can I take advantage of the changes? |
pbregener commentedMar 27, 2018
This MR is not merged, yet, so it's not "live" in the sense that it is part of any release or even current master. I guess the 5 commits should be squashed into one with a sensible commit message and then some maintainer should review and eventually merge it. |
There is also this regression on polar plots:#10882 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR. It looks like this works as expected.
jklymak commentedMar 27, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
PRs need two reviews. This looks reasonable, but it would be nice to know what PR the regression came in from and whether this was just an oversight or a design decision. |
pbregener commentedMar 27, 2018
Thanks. ping@QuLogic who is the local polar expert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks fine to me, but reluctant to merge w/o@QuLogic having a look..
If this really is a regression, it should probably be milestoned for v2.2.3 |
Its a 2.1 regression. Not sure on the policy there. |
pbregener commentedMar 27, 2018
It is a regression and as mentioned above, I would love to see this in Not sure about how matplotlib usually handles this, but I guess it would be nice to squash the five commits for this fairly trivial change into one@charlesruan |
@tacaswell said:
This would seem to fit. |
…raphs to have the correct alignments set.
965e5d9
toad70feb
CompareCommits have been squashed |
pbregener commentedApr 16, 2018
…lignments in polar graphs
@charlesruan thanks so much for this PR and your patience with the process! |
Backport PR#10792 on branch v2.2.x
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Previously polar graphs could not have their vertical/horizontal alignments set by set_rgrids(), this fix should re-enable this functionality.
Issue #10105
PR Checklist