This fix scales the radio buttons correctly with the size of the legend by taking the height that is already calculated for each section of the legend, which is defined by the variable dy (line 984). I took the dy value and converted appropriately into a radius (by dividing the value by 2) and subtracting a very small unit to allow for some spacing for in between the buttons. I made it default back into the previously hard-coded value of 0.05 if the value of the radius is any bigger so in the case where there isn't many radio buttons, they wouldn't be huge. Previously the value of the RadioButtons were set to 0.05 thus when the space given for each radio button was less then the 0.05 unit the buttons would overlap onto eachother.

Note: The tests seem to be failing at the image comparison tests for the radio button. Not entirely sure why, the test pass locally on my own machine. Any insight would be helpful, thank you.

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant

Abdul-Miraj added3 commits

March 14, 2018 06:36

fixed bug 4429 and created corrosponding testcase. As well as updated…

31a88a7

… a radio button testcase

Updated expected images of radio button tests

0433eb1

made testcase pep8 compliant

dee832e

QuLogic added the topic: widgets/UI label

Mar 14, 2018

Missed a few pep8 errors from earlier commit, this should be all of them

24e6bc3

Copy link

Contributor

afvincent commentedMar 14, 2018

Hum, about the failing image test comparison, I would suspect a Freetype issue as it is quite usual. See for example thissection in the documentation.

On top of that you could try to addremove_text=True to the image comparison decorator, to at least partly mitigate the issue with most of the fonts (the texts in the widgets are likely to stay visible, but the labels, tick labels and titles shoud be hidden IIRC). Being there, you could also addstyle='mpl20' to be more future-proof.

built the images using the correct freetype font as well as added som…

9c49c6a

…e headers to the radio button tests

Copy link

ContributorAuthor

Abdul-Miraj commentedMar 15, 2018•
edited
Loading

I original thought I was using the correct Freetype, as I set my setup.cfg correctly but realized it wasn't actually using the version mlp wanted. I had to delete my build folder and recompile the project for it to use the correct version#6911. Thank you!