Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Py3fy webagg/nbagg.#10708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Py3fy webagg/nbagg.#10708
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Do we not test any of NBAgg? |
No idea whether we do... |
I think that might be what the notebook in the |
Now there are some tests :) |
| try: | ||
| self.figure.draw(renderer) | ||
| super().draw() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
... this is pretty different. Does it do the same thing? Why just call super draw instead of the figure? Just trying to understand, not saying its wrong....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you're using Agg, this resolves tohttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backends/backend_agg.py#L414 which gets a cleared renderer, handles the locking and callsself.figure.draw(self.renderer).
Of course the not-so-secret objective here is to make it possible to swap in mplcairo's renderer. For that, the idea is as usual to push as much the renderer-specific code back to the super-class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense. I did findsuper().draw() a bit opaque.; ie. why not justself.draw()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
well that would be an infinite loop...
super().draw() means (approximately) "call the draw method but don't look it up on this class, look it up on the base class [in this case, FigureCanvasAgg] instead" (check up e.g. "python super mro" for details)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ooops. duh.
If you rebase this so your new tests are included, will the codecov go up? Did you test this w/ your new tests? |
(The locking of RendererAgg is already done by the super class, and thusredundant here.)
rebased. |
(The locking of RendererAgg is already done by the super class, and thus
redundant here.)
PR Summary
PR Checklist