Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Declare global variables that are created elsewhere#10689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jkseppan merged 1 commit intomatplotlib:masterfromcclauss:declare-globals
Apr 1, 2018

Conversation

cclauss
Copy link

Fixes#10502

PR Summary

Declareshow andFigureManager as global variables because they are created by an _@Backend.export decorator at the bottom or each file. Theglobal declaration and associated comment helps both humans and linters make sense of this non-intuitive situation.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymakjklymak added this to thev3.0 milestoneMar 5, 2018
@cclauss
Copy link
Author

@tacaswell@anntzer Your review of this approach?

Copy link
Contributor

@anntzeranntzer left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's kind of funny that this placates flake8 but I guess the point is that it cannot know all the places where a global could be introduced. I think it's a reasonable compromise.

Given that the global declaration is notactually needed, I'd make the comment more explicit: "...; declaration placates pyflakes" (something like that) (otherwise someone could just remove it at some point thinking it's redundant)

@cclauss
Copy link
Author

Comments updated as requested.

@jkseppanjkseppan merged commitb5b0003 intomatplotlib:masterApr 1, 2018
@cclausscclauss deleted the declare-globals branchApril 1, 2018 17:48
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jkseppanjkseppanjkseppan approved these changes

@anntzeranntzeranntzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

'FigureManager' is an undefined name in backend_wx.py
4 participants
@cclauss@jkseppan@anntzer@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp