Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix tk icon loading.#10681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 1 commit intomatplotlib:masterfromanntzer:tkicon
Mar 5, 2018
Merged

Fix tk icon loading.#10681

jklymak merged 1 commit intomatplotlib:masterfromanntzer:tkicon
Mar 5, 2018

Conversation

anntzer
Copy link
Contributor

Accidentally broke this for no good reason in#8773. Milestoning as 2.2 as it's fixing a bug introduced in 2.1.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev2.2.0 milestoneMar 5, 2018
@QuLogicQuLogic modified the milestones:v2.2.0,v2.2.1Mar 5, 2018
@dstansby
Copy link
Member

Is the best way to test this just open a plot in a tk window?

@anntzer
Copy link
ContributorAuthor

Yes

@dstansby
Copy link
Member

Hmm, I don't get an icon with the fix, but that might be an OSX thing.

@QuLogic
Copy link
Member

It works again, but it's kind of low resolution.

@jklymakjklymak merged commitcc127eb intomatplotlib:masterMar 5, 2018
lumberbot-appbot pushed a commit that referenced this pull requestMar 5, 2018
@anntzeranntzer deleted the tkicon branchMarch 6, 2018 00:33
dstansby added a commit that referenced this pull requestMar 6, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@jklymakjklymakjklymak approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v2.2.1
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@dstansby@QuLogic@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp