Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Small fixes to gtk3 examples.#10679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Move import of gi.repository.Gtk *after* matplotlib: this avoids thewarning "Gtk was imported without specifying a version first.", asMatplotlib itself calls `gi.require_version("Gtk", "3.0")`. Theexamples could be modified to also include the call to require_versionbut I'd rather decrease line noise as much as possible.- Make mpl_with_glade_316_sgskip work even when the example is not runfrom its folder (by looking for the glade file next to the source file).Sort of duplicated with#10426. |
No worries, that one can go in first then I can update or close this one. (Or please just close this if it is totally redundant.) |
Effectively overridden by#10426. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move import of gi.repository.Gtkafter matplotlib: this avoids the
warning "Gtk was imported without specifying a version first.", as
Matplotlib itself calls
gi.require_version("Gtk", "3.0"). Theexamples could be modified to also include the call to require_version
but I'd rather decrease line noise as much as possible.
Make mpl_with_glade_316_sgskip work even when the example is not run
from its folder (by looking for the glade file next to the source file).
Milestoning to 3.0 as these files were already modified during the py3fication.
PR Summary
PR Checklist