NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Support markers from Paths that consist of one line segment#10632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

phobson merged 1 commit intomatplotlib:masterfromlpsinger:short-marker-path

Mar 2, 2018

Merged

Support markers from Paths that consist of one line segment#10632

phobson merged 1 commit intomatplotlib:masterfromlpsinger:short-marker-path

Mar 2, 2018

Conversation

Copy link

Contributor

lpsinger commentedFeb 28, 2018

Theelif clauses inMarker.set_marker needed to be reordered because any Python object that has a__len__ method is an instance ofcollections.Sized.

Before this change, the new unit testtest_marker_path() would fail with this exception:

TypeError: 'Path' object does not support indexing

Support markers from Paths that consist of one line segment

82f8672

The `elif` clauses in `Marker.set_marker` needed to be reorderedbecause any Python object that has a `__len__` method is aninstance of `collections.Sized`.