Feb 28, 2018 · Feb 27, 2018 · Feb 27, 2018 · Feb 27, 2018 · Feb 28, 2018 · Feb 28, 2018
diff --git a/lib/matplotlib/axes/_subplots.py b/lib/matplotlib/axes/_subplots.py
        Make a twinx axes of self. This is used for twinx and twiny.
        """
        from matplotlib.projections import process_projection_requirements
        if'sharex' in kwargsand'sharey' in kwargs:
        ifkwargs["sharex"] is not selfandkwargs["sharey"] is not self:
            raise ValueError("Twinned Axes may share only one axis.")
        kl = (self.get_subplotspec(),) + kl
        projection_class, kwargs, key = process_projection_requirements(
Original file line number	Diff line number	Diff line change
Expand Up		@@ -172,7 +172,7 @@ def _make_twin_axes(self, kl, *kwargs):
		Make a twinx axes of self. This is used for twinx and twiny.
		"""
		from matplotlib.projections import process_projection_requirements
		if'sharex' in kwargsand'sharey' in kwargs:
		ifkwargs["sharex"] is not selfandkwargs["sharey"] is not self:
Copy link Member jklymakFeb 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This isn't the same as the old check at all 😉 Copy link ContributorAuthor stonebigFeb 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. hum, result is identical unless one of the 2 sharex/sharey is "self", isn't it ? Copy link Member dstansbyFeb 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think this needs to be a separate check as well as the one it has replaced right? The currently one checks that both x and y aren't shared at the same time, and you want to check that we're not trying to share an axis with itself. Copy link Contributor dopplershiftFeb 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. It will also give a`KeyError` if "sharex" and "sharey" aren't in`kwargs`. Copy link ContributorAuthor stonebigFeb 27, 2018 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. argh... ok, tuning
		raise ValueError("Twinned Axes may share only one axis.")
		kl = (self.get_subplotspec(),) + kl
		projection_class, kwargs, key = process_projection_requirements(
Expand Down