Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove some manual manipulation of whatsnew when releasing.#10573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rebased |
78d9dbd toe37028cCompareShould the doc builds not work? |
Can't reproduce the failure locally (the whatsnew gets included)... |
I suspect a rebase will fix this; I had this error for something as well that shouldn't have had the error, but it worked after a rebase? |
rebased |
Can you extend this to api_changes too? |
This PR ensures that the "unmerged" whatsnew entries get included in thedocs if and only if we're building the docs for a "local release", i.e.when the version number includes a git tag, but not a tagged release.This previously required manual manipulation.
Done. (but I guess it may still make sense to wait until the issue is fixed on sphinx's side before merging this, so that we don't start universally failing doc builds...) |
Temporarily closing until the issue is fixed upstream. |
This PR ensures that the "unmerged" whatsnew entries get included in the
docs if and only if we're building the docs for a "local release", i.e.
when the version number includes a git tag, but not a tagged release.
This previously required manual manipulation.
Noted while reviewing#10548.
PR Summary
PR Checklist