Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace is_numlike by isinstance(..., numbers.Number).#10468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:masterfromanntzer:numlike
Feb 15, 2018

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedFeb 15, 2018
edited
Loading

Since we bumped the min numpy version to 1.10, numpy scalars are now
also instances of numbers.Number.

Closes#7795.

(Related note: we can't do the same with iterable/isinstance(..., Iterable) as documented athttps://docs.python.org/3/library/collections.abc.html#collections.abc.Iterable.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev3.0 milestoneFeb 15, 2018
Since we bumped the min numpy version to 1.10, numpy scalars are nowalso instances of numbers.Number.
@QuLogicQuLogic merged commit962847d intomatplotlib:masterFeb 15, 2018
@anntzeranntzer deleted the numlike branchFebruary 15, 2018 20:59
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Incorrect uses of is_numlike
3 participants
@anntzer@QuLogic@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp