Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Delete deprecated backends#10426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Can we hold off on doing WX?@DietmarSchwertberger is interested in keeping it up. |
WX or WXAgg (which was not deprecated before)? |
OK, I restored There's one example |
6eff87e
to4c4fc0e
CompareThanks. I would be fine with a deprecation message for 3.0 for backend_wx.. |
QuLogic commentedFeb 12, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The WX renderer was alreadydeprecated in 2.0, but not WXAgg's. However, |
Removing just the WX renderer would make |
This PRis about 3.0, but the wx changes are reverted in any case. |
Sorry, did not see this. I just had in mind that the Wx backend was deprecated for rev. 2 already. |
import gtk | ||
import gi | ||
gi.require_version('Gtk', '3.0') | ||
from gi.repository import Gtk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rename "next" below to something else e.g. pos?
examples/widgets/cursor.py Outdated
@@ -20,7 +20,7 @@ | |||
ax.set_xlim(-2, 2) | |||
ax.set_ylim(-2, 2) | |||
#set useblit =True ongtkaggfor enhanced performance | |||
#Set useblit=True onsome backendsfor enhanced performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"useblit=True" improves the performance on most backends
? (gtk3cairo (fundamentally) cannot support blitting and I'm not sure what the situation is with nbagg but all other major backends do support blitting.)
examples/widgets/span_selector.py Outdated
@@ -38,7 +38,7 @@ def onselect(xmin, xmax): | |||
ax2.set_ylim(thisy.min(), thisy.max()) | |||
fig.canvas.draw() | |||
#set useblitTrue ongtkaggfor enhanced performance | |||
#Set useblit=True onsome backendsfor enhanced performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
see above
lib/matplotlib/pyplot.py Outdated
ml = gobject.MainLoop | ||
elif 'gtk' in sys.modules and 'gi' in sys.modules: | ||
from gi.repository import GObject | ||
ml = GObject.MainLoop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
squish into the next line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
minor stuff but not blocking merge
Fixed comments. |
Rebased due to conflicts. |
Rebased due to conflicts. |
It looks like we want to resolve the conflict by going with the master version, correct? |
Partly, we can still drop this |
Rebased due to conflicts. |
This silences a warning from PyGI.
It was part of the GTK2 backends, but not implemented for GTK3. Thisfile doesn't load in current Glade either.
Uh oh!
There was an error while loading.Please reload this page.
PR Summary
Remove GDK, GTK2, and
WXbackends, plus all deprecated methods in the backends. I need to go through a few of the examples to make sure they're okay.PR Checklist