Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Delete deprecated backends#10426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
efiring merged 10 commits intomatplotlib:masterfromQuLogic:delete-backends
Mar 5, 2018
Merged

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedFeb 12, 2018
edited
Loading

PR Summary

Remove GDK, GTK2, andWX backends, plus all deprecated methods in the backends. I need to go through a few of the examples to make sure they're okay.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogicQuLogic added this to thev3.0 milestoneFeb 12, 2018
@tacaswell
Copy link
Member

Can we hold off on doing WX?@DietmarSchwertberger is interested in keeping it up.

@QuLogic
Copy link
MemberAuthor

WX or WXAgg (which was not deprecated before)?

@QuLogic
Copy link
MemberAuthor

OK, I restoredbackend_wx.py for now as it's imported inbackend_wxagg.py, so we still need it at least partially. I'll leave it to@DietmarSchwertberger to determine whether to remove anything from there.

There's one examplelineprops_dialog_gtk_sgskip.py which usesDialogLineprops from the GTK2 backend, but this is not implemented in GTK3. I'm not sure whether this dialog should be implemented for GTK3 as well or the example deleted?

@QuLogicQuLogicforce-pushed thedelete-backends branch 2 times, most recently from6eff87e to4c4fc0eCompareFebruary 12, 2018 06:01
@DietmarSchwertberger
Copy link
Contributor

Thanks. I would be fine with a deprecation message for 3.0 for backend_wx..
By then, things should be decided.

@QuLogic
Copy link
MemberAuthor

QuLogic commentedFeb 12, 2018
edited
Loading

The WX renderer was alreadydeprecated in 2.0, but not WXAgg's. However,backend_wxagg.py usesbackend_wx.py. It doesn't look like the renderer is imported, so maybe only the renderer needs to be removed?

@QuLogicQuLogic changed the titleWIP: Delete deprecated backendsDelete deprecated backendsFeb 15, 2018
@QuLogicQuLogic mentioned this pull requestFeb 15, 2018
2 tasks
@DietmarSchwertberger
Copy link
Contributor

Removing just the WX renderer would makebackend_wx.py unusable on it's own, even though it could be imported.
Before 3.0 I would like to try whether the WX renderer can be used for rendering to wx.MetaFileDCs for creating EMF/WMF files. If that's not possible, it should be removed then. No matter what the outcome is, the WX backends will need restructuring for 3.0.
I would suggest not to do it for 2.2 as the risk for bugs is quite significant due to the tight schedule. (There are currently unmerged bugfix PRs.)

@QuLogic
Copy link
MemberAuthor

This PRis about 3.0, but the wx changes are reverted in any case.

@DietmarSchwertberger
Copy link
Contributor

Sorry, did not see this. I just had in mind that the Wx backend was deprecated for rev. 2 already.
I will take care for restructuring / clean up in time for 3.0.

import gtk
import gi
gi.require_version('Gtk', '3.0')
from gi.repository import Gtk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rename "next" below to something else e.g. pos?

@@ -20,7 +20,7 @@
ax.set_xlim(-2, 2)
ax.set_ylim(-2, 2)

#set useblit =True ongtkaggfor enhanced performance
#Set useblit=True onsome backendsfor enhanced performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"useblit=True" improves the performance on most backends? (gtk3cairo (fundamentally) cannot support blitting and I'm not sure what the situation is with nbagg but all other major backends do support blitting.)

@@ -38,7 +38,7 @@ def onselect(xmin, xmax):
ax2.set_ylim(thisy.min(), thisy.max())
fig.canvas.draw()

#set useblitTrue ongtkaggfor enhanced performance
#Set useblit=True onsome backendsfor enhanced performance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

see above

ml = gobject.MainLoop
elif 'gtk' in sys.modules and 'gi' in sys.modules:
from gi.repository import GObject
ml = GObject.MainLoop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

squish into the next line?

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

minor stuff but not blocking merge

@QuLogic
Copy link
MemberAuthor

Fixed comments.

@QuLogic
Copy link
MemberAuthor

Rebased due to conflicts.

@QuLogic
Copy link
MemberAuthor

Rebased due to conflicts.

@efiring
Copy link
Member

It looks like we want to resolve the conflict by going with the master version, correct?

@QuLogic
Copy link
MemberAuthor

Partly, we can still drop thisToolbar class that was deprecated (and now removed) in all backends.

@QuLogic
Copy link
MemberAuthor

Rebased due to conflicts.

@QuLogicQuLogic mentioned this pull requestMar 5, 2018
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@efiringefiringefiring approved these changes

@anntzeranntzeranntzer approved these changes

@auvipyauvipyauvipy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

6 participants
@QuLogic@tacaswell@DietmarSchwertberger@efiring@anntzer@auvipy

[8]ページ先頭

©2009-2025 Movatter.jp