Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

import matplotlib.pyplot as plt in axis_artist.py#10401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

cclauss
Copy link

$flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./lib/mpl_toolkits/axisartist/axis_artist.py:1624:11: F821 undefined name 'plt'    fig = plt.figure(1)          ^./lib/mpl_toolkits/axisartist/axis_artist.py:1653:5: F821 undefined name 'plt'    plt.draw()    ^./lib/mpl_toolkits/axisartist/axis_artist.py:1660:11: F821 undefined name 'plt'    fig = plt.figure(1)          ^./lib/mpl_toolkits/axisartist/axis_artist.py:1678:5: F821 undefined name 'plt'    plt.draw()    ^

@tacaswell
Copy link
Member

👎 This module definitely should not depend on pyplot.

These usages look like they are in some test functions at the bottom that are moved as part of#7545 .

Thank you for the work@cclauss , but I think this should be closed without merging.

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this module should not depend on pyplot, the usage is in test functions at the bottom.

@cclausscclaussforce-pushed theimport-matplotlib.pyplot-as-plt branch from441d5aa toca25d1eCompareFebruary 8, 2018 23:09
@cclauss
Copy link
Author

Move the import down into those functions that actually accessplt.

@QuLogic
Copy link
Member

I agree with@tacaswell and don't think we should move forward with this, but I'm somewhat biased as I opened#7545 😉.

@cclauss
Copy link
Author

Closing in favor of#7545 by popular request.

@cclausscclauss closed thisFeb 8, 2018
@cclausscclauss deleted the import-matplotlib.pyplot-as-plt branchFebruary 8, 2018 23:51
@tacaswell
Copy link
Member

Thanks@cclauss. Even though we did not merge this we still appreciate the effort!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@cclauss@tacaswell@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp