Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: re-jigger deprecation of rcParams using machinery in __init__#10379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
49bfe9d to8549a5bCompareAlternative to#10378 sorry, I did not see that one existed! I think this one is a bit better as it cleans out all of the internal usage. |
No problem. I was just hacking. Glad you have a proper solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This fixes Travis and local pytest for me.
| @@ -83,16 +83,16 @@ | |||
| if QT_API is None: | |||
| # No ETS environment or incompatible so use rcParams. | |||
| if rcParams['backend'] == 'Qt5Agg': | |||
| QT_API =rcParams['backend.qt5'] | |||
| QT_API =QT_API_PYQT5 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
OK, but this does't just deprecate the rcparam, it now ignores it, right? Is that what you wanted? Feel free to clear if so, but putting a red x so its noted..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, but the rc deprecation tools do not have a gentler option
PR Summary
This suppresses the warnings in the test suite and removes
PR Checklist