Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Hide the backend.qt4/5 rcparam deprecation warning in test suite.#10347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Otherwise, the test suite is spammed by warnings. Note that pytestexplicitly disregards warnings filters (pytest issue 2430) so we can'tjust set a filter when resetting the rcparams are reset in the testsuite.The changes in matplotlib.testing are just there to allow it to beimported relatively early in the matplotlib import process.
lib/matplotlib/rcsetup.py Outdated
| "The backend.qt5 rcParam was deprecated in version 2.2. In order " | ||
| "to force the use of a specificQt5 binding, either import that " | ||
| "to force the use of a specificQt4 binding, either import that " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Qt4->Qt5
jklymak approved these changesJan 30, 2018
I pushed a minor change |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. topic: testing
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, the test suite is spammed by warnings. Note that pytest
explicitly disregards warnings filters (pytest issue 2430) so we can't
just set a filter when resetting the rcparams are reset in the test
suite.
The changes in matplotlib.testing are just there to allow it to be
imported relatively early in the matplotlib import process.
labeling as release critical given the amount of spam on the test suite (if this, or another similar fix, cannot be merged, then we should revert#10282 until a better solution is found).
attn@efiring who first mentioned the issue to me.
PR Summary
PR Checklist