Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Alternate implementation of lazy ticks.#10302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:masterfromanntzer:lazyticks
Jan 24, 2018

Conversation

anntzer
Copy link
Contributor

@anntzeranntzer commentedJan 23, 2018•
edited
Loading

Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s for me).

I think this is closer than#9727 to being backcompatible, and also simpler if you understand how descriptors work. attn@timhoffm, obviously the credits of the idea go to him.

Milestoned to 2.2 to match#9727.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzeranntzer added this to thev2.2 milestoneJan 23, 2018
@anntzeranntzerforce-pushed thelazyticks branch 2 times, most recently frome2c7538 toce2ddeeCompareJanuary 24, 2018 01:31
@jklymakjklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labelJan 24, 2018
@jklymak
Copy link
Member

I'm not going to merge in case@efiring or@tacaswell want to have a look....

@jklymak
Copy link
Member

ooops, now there is a conflict. Probably w/ the other tick change?

Speeds up creation of 10x10 subplots ~4-fold (from 2.7s to 0.7s).
@anntzer
Copy link
ContributorAuthor

rebased

@timhoffmtimhoffm merged commitf3760b2 intomatplotlib:masterJan 24, 2018
@anntzeranntzer deleted the lazyticks branchJanuary 24, 2018 21:59
@anntzer
Copy link
ContributorAuthor

@timhoffm congrats on getting your commit bit, btw

@jklymak
Copy link
Member

@timhoffm Yes, welcome!

Though I think out of an abundance of caution we make sure (most of) the tests pass before committing 😉 Maybe OK in this case, as the pre-rebase passed, but...

@timhoffm
Copy link
Member

Thanks.@jklymak also thanks for the advice. I will wait next time.

@QuLogicQuLogic modified the milestones:needs sorting,v2.2.0Feb 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@jklymak@timhoffm@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp