NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Deprecate the backend.qt{4,5} rcParams.#10282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:deprecate-backend-qt45

Jan 29, 2018

Merged

Deprecate the backend.qt{4,5} rcParams.#10282

tacaswell merged 1 commit intomatplotlib:masterfromanntzer:deprecate-backend-qt45

Jan 29, 2018

Conversation

Copy link

Contributor

anntzer commentedJan 22, 2018•
edited
Loading

For the rcParams rewrite (MEP32), they may make it tricky to
transform rcParams into a nested dictionary type of object, as "backend"
is already the name of another (more important) rcParam.
(I haven't decided on a nested dict design yet, just keeping options open.)
This specific issue could be solved with deprecation + renaming, but also...
The use of these rcParams can easily be replaced by a) first
importing one of the bindings (qt_compat will ensure that the already
imported binding gets used, as importing multiple bindings in the same
process is a bad idea anyways), or b) setting the QT_API environment
variable appropriately.

Milestoning as 2.2 so that the rcparams may actually get removed when (if) MEP32 makes it in 3.0, but feel free to push back too.

PR Summary

PR Checklist

Has Pytest style unit tests
Code is PEP 8 compliant
New features are documented, with examples if plot related
Documentation is sphinx and numpydoc compliant
Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer added this to thev2.2 milestone

Jan 22, 2018

Deprecate the backend.qt{4,5} rcParams.

188a4af

1) For the rcParams rewrite (MEP32), they may make it tricky totransform rcParams into a nested dictionary type of object, as "backend"is already the name of another (more important) rcParam.  This specificissue could be solved with deprecation + renaming, but also...2) The use of these rcParams can easily be replaced by a) firstimporting one of the bindings (qt_compat will ensure that the alreadyimported binding gets used, as importing multiple bindings in the sameprocess is a bad idea anyways), or b) setting the QT_API environmentvariable appropriately.

anntzer force-pushed thedeprecate-backend-qt45 branch from0efd32d to188a4afCompare

January 22, 2018 06:07

jklymak added the Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label

Jan 24, 2018

Copy link

Member

jklymak commentedJan 24, 2018

So, is an alternative to make new rcParams that do the same thing? I don't use these rcParams, but maybe some people do. I'm not sure about the goal here other than an rcParams namespace issue?

Copy link

ContributorAuthor

anntzer commentedJan 24, 2018

Renaming would be the other option, but again I think QT_API or preimporting either module is good enough. Of course, we'll see how much pushback we get after releasing this...