Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't use gdb on Travis (as it breaks the build).#10223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
anntzer wants to merge1 commit intomatplotlib:masterfromanntzer:travis-no-gdb

Conversation

anntzer
Copy link
Contributor

PR Summary

Let's see whether this helps unbreaking the build...

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member

Duplicate (plus or minus an 'x')#10217...

@jklymak
Copy link
Member

... which as we can see,does unbreak the builds.

@anntzer
Copy link
ContributorAuthor

Oh, sorry, I saw@QuLogic's original PR but missed your changes.

@anntzeranntzer deleted the travis-no-gdb branchJanuary 10, 2018 21:20
@jklymak
Copy link
Member

Did we want -ex for 'set'? Its '-v' for#10217 ?

@anntzer
Copy link
ContributorAuthor

I would keep "set -e" (and thus drop the "return $?"); set -x is nice as it removes the need to echo the pytest args ourselves (it's exactly what -x does...); -x also makes -v a bit redundant.
So overall I like -ex...

@jklymak
Copy link
Member

Done!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@anntzer@jklymak
[8]ページ先頭
©2009-2025 Movatter.jp