Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add some wx specific tools for ToolManager#10208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

DietmarSchwertberger
Copy link
Contributor

PR Summary

This is a first implementation of the main ToolManager Tools for the wx backends:
SaveFigure, SetCursor and Rubberband
There's no ToolbarWx implementation. The tools are for embedding a FigureCanvasWxAgg and to be triggered by the program.

This is a replacement for PR#10145.

It was tested under Windows/Python 3.6/Phoenix and Mac OS/Python 2.7/wxPython 3.0.2.

The implementation of Rubberband under Mac OS is not optimal, but overlays and DC.SetLogicalFunction do not work on Mac OS on any wxPython version.
Re-using the Mac OS rubberband code from the NavigationToolbar2Wx would have created quite unreadable code as RubberbandBase is using screen coordinates. The code could probably be optimized with a changed implementation of FigureCanvasWxAgg.

The other tools are mainly copy & paste from NavigationToolbar2Wx and the Qt/GTK3/Tk implementations of the tools.

My motivation for the current pull requests is to ship a fully working example with wxGlade that demonstrates how to build a GUI with a matplotlib canvas and use most of the control features that people would need. I could strip down this example if required. The full example is probably too large for distribution with matplotlib and also it's not finished yet.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@tacaswelltacaswell added this to thev2.2 milestoneJan 9, 2018
@DietmarSchwertbergerDietmarSchwertberger changed the titleBaadd some wx specific tools for ToolManagerAdd some wx specific tools for ToolManagerFeb 11, 2018
@DietmarSchwertbergerDietmarSchwertberger mentioned this pull requestFeb 11, 2018
6 tasks
@tacaswell
Copy link
Member

@DietmarSchwertberger I took the liberty of pushing a fix for the style check failure.

@DietmarSchwertberger
Copy link
ContributorAuthor

Sure, thanks, I did not see this one. The original from 'NavigationToolbar2Wx' was multi-line...

@tacaswell
Copy link
Member

ok, lets try that again....

@tacaswelltacaswell merged commit001368f intomatplotlib:masterFeb 12, 2018
@tacaswell
Copy link
Member

Thanks!

The failure looks like a transient.

@DietmarSchwertbergerDietmarSchwertberger deleted the BACKENDWX_TOOLMANAGER_TOOLS branchFebruary 12, 2018 01:26
@QuLogicQuLogic modified the milestones:needs sorting,v2.2.0Feb 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

3 participants
@DietmarSchwertberger@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp