Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Catch normed warning in tests#10200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| ax.hist((d1, d2), stacked=True, normed=True) | ||
| fig, ax= plt.subplots() | ||
| with pytest.warns(UserWarning): | ||
| ax.hist((d1, d2), stacked=True, normed=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Instead of catching the warning, why not stop using the deprecated 'normed' kwarg in the tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Because although it's deprecated, it should still work until removed (and we should be testing that it still works)
@dstansby can you rebase? This seems to be failing on the gdb issue. |
Another "normed kwarg to hist is deprecated" catch