NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Add method for comparing two colors#10032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jklymak merged 3 commits intomatplotlib:masterfromdstansby:same-color

Dec 21, 2017

Merged

Add method for comparing two colors#10032

jklymak merged 3 commits intomatplotlib:masterfromdstansby:same-color

Dec 21, 2017

Conversation

Copy link

Member

dstansby commentedDec 17, 2017•
edited
Loading

Colors in Matplotlib can come in many weird and wonderful forms; this allows two colors to be compared.

dstansby added3 commits

December 17, 2017 12:47

Add method for comparing two colors

93b61b6

Spelling mistake

acd94e1

Add array compatability

b06cae8

dstansby mentioned this pull request

Dec 17, 2017

Fix legend color comparisions#10031

Merged

tacaswell added this to thev2.2 milestone

Dec 18, 2017

tacaswell approved these changes

Dec 18, 2017

View reviewed changes

Copy link

Member

WeatherGod commentedDec 18, 2017 via email

Will need a what's new entry, won't it?

…

On Mon, Dec 18, 2017 at 3:14 PM, Thomas A Caswell ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#10032 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-NLFTC9rUD_jto6ZhCjiH5UsweUEks5tBseUgaJpZM4REpQf> .

Copy link

Member

tacaswell commentedDec 18, 2017

👍@WeatherGod sorry I missed that.

efiring approved these changes

Dec 18, 2017

View reviewed changes

Copy link

Member

efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks reasonable; I wonder where it would be used, apart from the legend?

Copy link

MemberAuthor

dstansby commentedDec 18, 2017

There might be other bits of the codebase that compare if two colors are equal?

Even if there aren't I think it's a useful user function to have given then many different ways colors can be specified, and it makes it clear in our internal code when we are comparing colors for equality.

Will add a what's new when I get time, or if someone wants to push one to my branch feel free.

Copy link

Member

tacaswell commentedDec 18, 2017

I think this is the first step towards a more consistent color representation at the python layer.

Copy link

Member

jklymak commentedDec 18, 2017

Right - see#9995. It would prob make sense to have acolor class that then did all this automagically.

Copy link

Member

WeatherGod commentedDec 18, 2017 via email

Other thing to consider is how this would fold in with traitlets (don'tknow where we currently stand on that.)

…

On Mon, Dec 18, 2017 at 5:19 PM, Jody Klymak ***@***.***> wrote: Right - see#9995 <#9995>. It would prob make sense to have a color class that then did all this automagically. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10032 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-I53v7kIeDIv4Lxsu4ZKnp1ns76Yks5tBuTYgaJpZM4REpQf> .