Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Description
Reviewing the changes in#5774, I realized that one of the original proposals from the BoF, of fixing up the dash styles to be less terrible, got lost somewhere along the way. IMO the current non-solid dash styles are pretty much unusable. Each on its own might be okay, but when you use them on the same plot (and isn't the whole point of these that you put them on the same plot to make it easier to tell lines apart?), then they have wildly varying visual weights and the dotted style in particular is almost invisible. (This is similar to the problem with the old color cycle, where some colors high much higher contrast than others; fixing that required switching to a set of isoluminant colors. Similarly, we should make the dash style closer to isoluminant.)
Here's a quick mock-up of a better set of dash styles. Left is#5774; right is#5774 + better dash styles:
(Code:https://gist.github.com/njsmith/ad4958cd1eb674fbed67)
The reason this is an issue rather than a pull request is that it looks like currently the dash styles are hard-coded constants inGraphicsContextBase
and can't be touched by the RC system, and I'm not familiar enough with the life-cycle ofGraphicsContext
objects and their interaction with the RC system to fix this without some hints. Happy to make a PR if someone points me in the right direction :-)