Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Closed
Labels
Milestone
Description
Summary
setuptools-scm released today and even after the biggest issue having been resolved and the 8.0.0 release being yanked we are seeing CI failures, primarily on azure.
This is mostly me documenting what I'm seeing, probably mostly for myself, but if others have insights/opinions, happy to hear them
There are actually two seemingly disjoint problems:
setuptools-scm is complaining that we do not have config in
pyproject.toml
- There is a release note stating "remove legacy version parser api - config arg always required"
- Despite this, appears to actually install and get the version number and everything, so not fully sure what is required
Azure CI is picking up an older version of
setuptools
, despite having apparently installed the latest version.setuptools-scm
is issuing a runtime warning for older setuptools, which is failing testssetuptools-scm
doesnot pin the version ofsetuptools
in their requirements, despite having checks against specific versionssetuptools-scm
now requires setuptools>=61- During install, it appears that setuptools 68 is installed on the Azure runs, so thereshouldn't be a CI problem
- But it is still picking up setuptools 58 at runtime
Proposed fix
Possible solutions:
Pin setuptools-scm<8
- not super viable long term, and if we can just fix compatibility easily, probably better, but if it is hard in the interim, may be a stopgap to employ.
Pin our own version of setuptools
- Not sure it would help as it looks like newer is installed in CI, but may not hurt
Add config to pyproject.toml
- need to determine what even needs to go in here, as far as I'm aware, we don't use any non-default settings
- From their readme, looks like it can be an empty toml table or at most specifying where the version file goes... if the former, I think it is strange to error on missing, but not hard to add I guess...
Figure out where azure is getting the older setuptools from?
- is it preinstalled and on
sys.path
first? - Seems to only be on the 3.9 builds, but that may be because of the Azure images?
- is it preinstalled and on