Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Description
Summary
Version 3.6 of Matplotlib deprecates theseaborn style names, and renames themseaborn-v0_8. Renaming them causes technical debt to current users of these styles, and also creates technical debt in future as other styles may need to be renamed for consistency.
Proposed fix
I agree that each step of this decision starting fromthis PR was sensible, and yet, as an end user, I found the net effect of this change to be very user-unfriendly (I came across it when my Read the Docs builds started failing). As someonehere commented, they like Matplotlib'sggplot style regardless of whether it maps onto the current version ofggplot. What happens ifggplot changes its default style? What aboutfivethirtyeight? Are all of these styles going to end up with awkwardly versioned names? I know I'll feel frustrated struggling to remember whether these styles are namedseaborn0.8,seaborn-v08,seaborn_v0_8, etc. Since these styles exist purely for convenience (otherwise, you can just use Seaborn), making them significantly less convenient seems to defeat the purpose of including them.
While I agree it's not ideal to have styles namedseaborn that don't (necessarily) match the current versions in Seaborn, I think the alternative of renaming them to a specific version (a) causes extra work for (the vast majority of) users who just want the styles to work, (b) is confusing since listing one version implies that other versions will exist, (c) creates technical debt by setting a precedent for needing to update other plotting styles. Thus, I would argue that the best among the set of not-great options is just to leave these styles -- and their names -- as-is.