Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[MNT]: Remove origin and extents parameters from tricontour[f]() #24006

Open
@timhoffm

Description

@timhoffm

Summary

from:#23995 (comment)

tricontour[f] documents and accepts parametersorigin andextent, but interestingly, they are not used 😲. They are only used incontour[f], where one can leave out X and Y, in which caseorigin andextent define where to place the data in the Axes. When one thinks about it, this concept does obviously does not apply to triangular grids. One always has to specify x and y, either directly or via a `Triangulation.

It's a bit hard to see thatorigin andextent are unused, because they are passed through multiple levels of kwargs and are added as attributes toContourSet, which is the common base class ofTriContourSet andQuadContourSet. ButTriContourSet does not use them. One can also check this by removing the validation checks on these values and then passing in nonsense values: The plot does not care. It seems this docstring part was copied fromcontour[f] without thinking about it.

Proposed fix

Goal: Removeorigin andextents parameters fromtricontour[f]()

Things to do:

  • Find out the how to properly handleorigin andextent in theContourSet class hierarchy. Likely move toQuadContourSet. But it might be that we have leave it inContourSet but warn/error when used inTriContourSet.
  • Based on that determine the proper place to deprecate them.
  • Change thetricontour[f] docstring accordingly (deprecation statement and mention that they don't have any effect).
  • When the deprecation expires, clean up.

Note: Nobody has complained that these parameters don't have any effect, so I assume nobody uses them intentionally. But since they are documented, I think we still have to jump the deprecation hoops.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp