Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[SPRINT] Add warning for mixing AnchoredText with bad kwarg#2166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| propkeys = prop.keys() | ||
| badkwargs = ('ha', 'horizontalalignment', 'va', 'verticalalignment') | ||
| for badkwarg in badkwargs: | ||
| if badkwarg in propkeys: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
could be done with a set comparison. something likeif set(propkeys) & set(badkwargs): to avoid the loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, that's a much better idea.
Mixing 'ha' or 'va' with AnchoredText produces bad output, so add a warning inthis case.
[SPRINT] Add warning for mixing AnchoredText with bad kwarg
Mixing 'ha' or 'va' with AnchoredText produces bad output, so add a warning in
this case.
Addresses#1742.