Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Description
Describe the issue
In#16154/#19026 I am deprecating implicitly setting the pickradius of an Artist viaset_picker(<number>)
, because this causes various arising from the fact thatTrue == 1
andFalse == 0
(listed in the discussions of the issues above). I am still convinced that this change is for the better. However, now there are a few places where calls toset_picker(<number>)
(usually implicit though kwargs, e.g.plot(..., picker=<number>)
) now need to be replaced byset(picker=True, pickradius=<number>)
, which is perhaps unnecessarily verbose (I'd guess the vast majority of people setting the pickradius indeed want to turn on picking). So we could consider makingset_pickradius()
also implicitly callset_picker(True)
, or perhaps even internally differentiatepicker = <unset>
(i.e., False, but gets turned on byset_pickradius
) andpicker = None
(i.e. disabled). Or we could just decide that this whole deprecation was not worth it and go back to overloadingpicker
to support pickradius values.
Thoughts?