Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Shouldset_pickradius() implicitly callset_picker(True)? #19039

Open
@anntzer

Description

@anntzer

Describe the issue

In#16154/#19026 I am deprecating implicitly setting the pickradius of an Artist viaset_picker(<number>), because this causes various arising from the fact thatTrue == 1 andFalse == 0 (listed in the discussions of the issues above). I am still convinced that this change is for the better. However, now there are a few places where calls toset_picker(<number>) (usually implicit though kwargs, e.g.plot(..., picker=<number>)) now need to be replaced byset(picker=True, pickradius=<number>), which is perhaps unnecessarily verbose (I'd guess the vast majority of people setting the pickradius indeed want to turn on picking). So we could consider makingset_pickradius() also implicitly callset_picker(True), or perhaps even internally differentiatepicker = <unset> (i.e., False, but gets turned on byset_pickradius) andpicker = None (i.e. disabled). Or we could just decide that this whole deprecation was not worth it and go back to overloadingpicker to support pickradius values.

Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions


      [8]ページ先頭

      ©2009-2025 Movatter.jp