NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Commitfe4b36b

committed

Fix format_cursor_data with nans.

Without this fix, hovering the mouse over a nan pixel in an imshow()would result in `Warning: converting a masked element to nan.` and then`ValueError: cannot convert float NaN to integer`. Fix that.The format_cursor_data test doesn't explicitly check the return valueof get_cursor_data anymore because np.ma.masked is returned for naninputs (this is expected from the general approach for handling invaliddata); checking that format_cursor_data gives the right string issufficient.

1 parenta35f108 commitfe4b36bCopy full SHA for fe4b36b

File tree

2 files changed

-1

lines changed

lib/matplotlib
- artist.py
- tests
  - test_image.py

2 files changed

-1

lines changed

`‎lib/matplotlib/artist.py`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1273,6 +1273,8 @@ def format_cursor_data(self, data):`
`1273`	`1273`	`# from Artist first and from ScalarMappable second, so`
`1274`	`1274`	`# Artist.format_cursor_data would always have precedence over`
`1275`	`1275`	`# ScalarMappable.format_cursor_data.`
	`1276`	`+ifnp.ma.getmask(data):`
	`1277`	`+return"[]"`
`1276`	`1278`	`n=self.cmap.N`
`1277`	`1279`	`# Midpoints of neighboring color intervals.`
`1278`	`1280`	`neighbors=self.norm.inverse(`

`‎lib/matplotlib/tests/test_image.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -340,6 +340,7 @@ def test_cursor_data():`
`340`	`340`	`"data, text", [`
`341`	`341`	`([[10001,10000]],"[10001.000]"),`
`342`	`342`	`([[.123,.987]],"[0.123]"),`
	`343`	`+ ([[np.nan,1,2]],"[]"),`
`343`	`344`	`])`
`344`	`345`	`deftest_format_cursor_data(data,text):`
`345`	`346`	`frommatplotlib.backend_basesimportMouseEvent`
`@@ -349,7 +350,6 @@ def test_format_cursor_data(data, text):`
`349`	`350`
`350`	`351`	`xdisp,ydisp=ax.transData.transform([0,0])`
`351`	`352`	`event=MouseEvent('motion_notify_event',fig.canvas,xdisp,ydisp)`
`352`		`-assertim.get_cursor_data(event)==data[0][0]`
`353`	`353`	`assertim.format_cursor_data(im.get_cursor_data(event))==text`
`354`	`354`
`355`	`355`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitfe4b36b

File tree

2 files changed

2 files changed

`‎lib/matplotlib/artist.py`

`‎lib/matplotlib/tests/test_image.py`

0 commit comments