NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Commitf9bb816

authored

Merge pull request#23834 from timhoffm/revert-code-cleanup

Revert "Refactor handling of tick and ticklabel visiblity in Axis.clear"

2 parentsed5dc21 +df5648d commitf9bb816Copy full SHA for f9bb816

File tree

1 file changed

-28

lines changed

lib/matplotlib
- axis.py

1 file changed

-28

lines changed

`‎lib/matplotlib/axis.py‎`

Lines changed: 8 additions & 28 deletions

Original file line number	Diff line number	Diff line change
`@@ -846,36 +846,14 @@ def get_children(self):`
`846`	`846`	`return [self.label,self.offsetText,`
`847`	`847`	`self.get_major_ticks(),self.get_minor_ticks()]`
`848`	`848`
`849`		`-def_reset_major_tick_kw(self,keep_tick_and_label_visibility=False):`
`850`		`-"""`
`851`		`- Reset major tick params to defaults.`
`852`		`-`
`853`		`- Shared subplots pre-configure tick and label visibility. To keep this`
`854`		`- beyond an Axis.clear() operation, we may`
`855`		`- keep_tick_and_label_visibility.`
`856`		`- """`
`857`		`-backup= {name:valueforname,valueinself._major_tick_kw.items()`
`858`		`-ifnamein ['tick1On','tick2On','label1On','label2On']}`
	`849`	`+def_reset_major_tick_kw(self):`
`859`	`850`	`self._major_tick_kw.clear()`
`860`		`-ifkeep_tick_and_label_visibility:`
`861`		`-self._major_tick_kw.update(backup)`
`862`	`851`	`self._major_tick_kw['gridOn']= (`
`863`	`852`	`mpl.rcParams['axes.grid']and`
`864`	`853`	`mpl.rcParams['axes.grid.which']in ('both','major'))`
`865`	`854`
`866`		`-def_reset_minor_tick_kw(self,keep_tick_and_label_visibility=False):`
`867`		`-"""`
`868`		`- Reset minor tick params to defaults.`
`869`		`-`
`870`		`- Shared subplots pre-configure tick and label visibility. To keep this`
`871`		`- beyond an Axis.clear() operation, we may`
`872`		`- keep_tick_and_label_visibility.`
`873`		`- """`
`874`		`-backup= {name:valueforname,valueinself._minor_tick_kw.items()`
`875`		`-ifnamein ['tick1On','tick2On','label1On','label2On']}`
	`855`	`+def_reset_minor_tick_kw(self):`
`876`	`856`	`self._minor_tick_kw.clear()`
`877`		`-ifkeep_tick_and_label_visibility:`
`878`		`-self._minor_tick_kw.update(backup)`
`879`	`857`	`self._minor_tick_kw['gridOn']= (`
`880`	`858`	`mpl.rcParams['axes.grid']and`
`881`	`859`	`mpl.rcParams['axes.grid.which']in ('both','minor'))`
`@@ -892,8 +870,6 @@ def clear(self):`
`892`	`870`	`- major and minor grid`
`893`	`871`	`- units`
`894`	`872`	`- registered callbacks`
`895`		`-`
`896`		`- This does not reset tick and tick label visibility.`
`897`	`873`	`"""`
`898`	`874`	`self.label._reset_visual_defaults()`
`899`	`875`	`self.offsetText._reset_visual_defaults()`
`@@ -908,8 +884,12 @@ def clear(self):`
`908`	`884`	`signals=["units","units finalize"])`
`909`	`885`
`910`	`886`	`# whether the grids are on`
`911`		`-self._reset_major_tick_kw(keep_tick_and_label_visibility=True)`
`912`		`-self._reset_minor_tick_kw(keep_tick_and_label_visibility=True)`
	`887`	`+self._major_tick_kw['gridOn']= (`
	`888`	`+mpl.rcParams['axes.grid']and`
	`889`	`+mpl.rcParams['axes.grid.which']in ('both','major'))`
	`890`	`+self._minor_tick_kw['gridOn']= (`
	`891`	`+mpl.rcParams['axes.grid']and`
	`892`	`+mpl.rcParams['axes.grid.which']in ('both','minor'))`
`913`	`893`	`self.reset_ticks()`
`914`	`894`
`915`	`895`	`self.converter=None`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitf9bb816

File tree

1 file changed

1 file changed

`‎lib/matplotlib/axis.py‎`

0 commit comments