Commitf8b814e

authored

Merge pull request#18754 from tacaswell/fix_log_ticks

FIX: make sure we have more than 1 tick with small log ranges

2 parentsd872350 +b23a874 commitf8b814eCopy full SHA for f8b814e

File tree

+17

-0

lines changed

+17

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1362,3 +1362,13 @@ def test_bad_locator_subs(sub):`
`1362`	`1362`	`ll=mticker.LogLocator()`
`1363`	`1363`	`withpytest.raises(ValueError):`
`1364`	`1364`	`ll.subs(sub)`
	`1365`	`+`
	`1366`	`+`
	`1367`	`+@pytest.mark.parametrize('numticks', [1,2,3,9])`
	`1368`	`+@pytest.mark.style('default')`
	`1369`	`+deftest_small_range_loglocator(numticks):`
	`1370`	`+ll=mticker.LogLocator()`
	`1371`	`+ll.set_params(numticks=numticks)`
	`1372`	`+fortopin [5,7,9,11,15,50,100,1000]:`
	`1373`	`+ticks=ll.tick_values(.5,top)`
	`1374`	`+assert (np.diff(np.log10(ll.tick_values(6,150)))==1).all()`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2479,6 +2479,13 @@ def tick_values(self, vmin, vmax):`
`2479`	`2479`	`ifmpl.rcParams['_internal.classic_mode']else`
`2480`	`2480`	`(numdec+1)//numticks+1)`
`2481`	`2481`
	`2482`	`+# if we have decided that the stride is as big or bigger than`
	`2483`	`+# the range, clip the stride back to the available range - 1`
	`2484`	`+# with a floor of 1. This prevents getting axis with only 1 tick`
	`2485`	`+# visible.`
	`2486`	`+ifstride>=numdec:`
	`2487`	`+stride=max(1,numdec-1)`
	`2488`	`+`
`2482`	`2489`	`# Does subs include anything other than 1? Essentially a hack to know`
`2483`	`2490`	`# whether we're a major or a minor locator.`
`2484`	`2491`	`have_subs=len(subs)>1or (len(subs)==1andsubs[0]!=1.0)`

Comments

(0)