Commitf855dde

authored

Merge pull request#21574 from meeseeksmachine/auto-backport-of-pr-21570-on-v3.4.x

Backport PR#21570 on branch v3.4.x (Raise correct exception out of Spines.__getattr__)

2 parents6510bc4 +63cc389 commitf855ddeCopy full SHA for f855dde

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -550,7 +550,7 @@ def __getattr__(self, name):`
`550`	`550`	`try:`
`551`	`551`	`returnself._dict[name]`
`552`	`552`	`exceptKeyError:`
`553`		`-raiseValueError(`
	`553`	`+raiseAttributeError(`
`554`	`554`	`f"'Spines' object does not contain a '{name}' spine")`
`555`	`555`
`556`	`556`	`def__getitem__(self,key):`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ def set_val(self, val):`
`35`	`35`	`spines[:].set_val('y')`
`36`	`36`	`assertall(spine.val=='y'forspineinspines.values())`
`37`	`37`
	`38`	`+withpytest.raises(AttributeError,match='foo'):`
	`39`	`+spines.foo`
`38`	`40`	`withpytest.raises(KeyError,match='foo'):`
`39`	`41`	`spines['foo']`
`40`	`42`	`withpytest.raises(KeyError,match='foo, bar'):`

Comments

(0)