Commitf5c9e19

authored

Merge pull request#17609 from tacaswell/auto-backport-of-pr-17602-on-v3.2.x

Backport PR#17602: FIX: propagate _is_saving state when changing can…

2 parents889c73f +6afbad4 commitf5c9e19Copy full SHA for f5c9e19

File tree

+12

-2

lines changed

+12

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2068,8 +2068,9 @@ def print_figure(self, filename, dpi=None, facecolor=None, edgecolor=None,`
`2068`	`2068`	`# Some code (e.g. Figure.show) differentiates between having no`
`2069`	`2069`	`# manager and a None manager, which should be fixed at some point,`
`2070`	`2070`	`# but this should be fine.`
`2071`		`-withcbook._setattr_cm(self,_is_saving=True,manager=None), \`
`2072`		`-cbook._setattr_cm(self.figure,dpi=dpi):`
	`2071`	`+withcbook._setattr_cm(self,manager=None), \`
	`2072`	`+cbook._setattr_cm(self.figure,dpi=dpi), \`
	`2073`	`+cbook._setattr_cm(canvas,_is_saving=True):`
`2073`	`2074`
`2074`	`2075`	`iffacecolorisNone:`
`2075`	`2076`	`facecolor=rcParams['savefig.facecolor']`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -487,3 +487,12 @@ def test_removed_axis():`
`487`	`487`	`fig,axs=plt.subplots(2,sharex=True)`
`488`	`488`	`axs[0].remove()`
`489`	`489`	`fig.canvas.draw()`
	`490`	`+`
	`491`	`+`
	`492`	`+@check_figures_equal(extensions=["svg","pdf","eps","png"])`
	`493`	`+deftest_animated_with_canvas_change(fig_test,fig_ref):`
	`494`	`+ax_ref=fig_ref.subplots()`
	`495`	`+ax_ref.plot(range(5))`
	`496`	`+`
	`497`	`+ax_test=fig_test.subplots()`
	`498`	`+ax_test.plot(range(5),animated=True)`

Comments

(0)