Commitecb384e

cmp0xff

and

timhoffm

committed

Apply suggestions from code review

-https://github.com/matplotlib/matplotlib/pull/29325/files#r1894693106-https://github.com/matplotlib/matplotlib/pull/29325/files#r1894693188-https://github.com/matplotlib/matplotlib/pull/29325/files#r1894696478Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>

1 parente9ce871 commitecb384eCopy full SHA for ecb384e

File tree

2 files changed

+25

-15

lines changed

lib/matplotlib
- axes
  - _base.py
- tests
  - test_axes.py

2 files changed

+25

-15

lines changed

`‎lib/matplotlib/axes/_base.py`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4613,6 +4613,8 @@ def twinx(self, axes_class=None, **kwargs):`
`4613`	`4613`	`is incompatible with projection and polar. See`
`4614`	`4614`	:ref:`axisartist_users-guide-index` for examples.
`4615`	`4615`
	`4616`	+ By default, `~.axes.Axes` is used.
	`4617`	`+`
`4616`	`4618`	`kwargs : dict`
`4617`	`4619`	The keyword arguments passed to ``add_subplot()`` or ``add_axes()``.
`4618`	`4620`
`@@ -4656,6 +4658,8 @@ def twiny(self, axes_class=None, **kwargs):`
`4656`	`4658`	`is incompatible with projection and polar. See`
`4657`	`4659`	:ref:`axisartist_users-guide-index` for examples.
`4658`	`4660`
	`4661`	+ By default, `~.axes.Axes` is used.
	`4662`	`+`
`4659`	`4663`	`kwargs : dict`
`4660`	`4664`	The keyword arguments passed to ``add_subplot()`` or ``add_axes()``.
`4661`	`4665`

`‎lib/matplotlib/tests/test_axes.py`

Lines changed: 21 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -7538,21 +7538,27 @@ def __init__(self, args, foo, *kwargs):`
`7538`	`7538`	`self.foo=foo`
`7539`	`7539`
`7540`	`7540`
`7541`		`-@pytest.mark.parametrize("twinning", ["twinx","twiny"])`
`7542`		`-@pytest.mark.parametrize(("axes_class","kw0","kw1"), [`
`7543`		`- (Axes, {}, {}),`
`7544`		`- (SubclassAxes, {"foo":0}, {"foo":1}),`
`7545`		`-])`
`7546`		`-deftest_twinning_subclass(twinning,axes_class,kw0,kw1):`
`7547`		`-fig=plt.figure()`
`7548`		`-classed_ax=fig.add_subplot(axes_class=axes_class,**kw0)`
`7549`		`-fork,vinkw0.items():`
`7550`		`-assertgetattr(classed_ax,k)==v`
`7551`		`-`
`7552`		`-twin=getattr(classed_ax,twinning)(axes_class=axes_class,**kw1)`
`7553`		`-asserttype(twin)isaxes_class`
`7554`		`-fork,vinkw1.items():`
`7555`		`-assertgetattr(twin,k)==v`
	`7541`	`+deftest_twinning_with_axes_class():`
	`7542`	`+"""Check that twinx/y(axes_class=...) gives the appropriate class."""`
	`7543`	`+_,ax=plt.subplots()`
	`7544`	`+twinx=ax.twinx(axes_class=SubclassAxes,foo=1)`
	`7545`	`+assertisinstance(twinx,SubclassAxes)`
	`7546`	`+asserttwinx.foo==1`
	`7547`	`+twiny=ax.twiny(axes_class=SubclassAxes,foo=2)`
	`7548`	`+assertisinstance(twiny,SubclassAxes)`
	`7549`	`+asserttwiny.foo==2`
	`7550`	`+`
	`7551`	`+`
	`7552`	`+deftest_twinning_default_axes_class():`
	`7553`	`+"""`
	`7554`	`+ Check that the default class for twinx/y() is Axes,`
	`7555`	`+ even if the original is an Axes subclass.`
	`7556`	`+ """`
	`7557`	`+_,ax=plt.subplots(subplot_kw=dict(axes_class=SubclassAxes,foo=1))`
	`7558`	`+twinx=ax.twinx()`
	`7559`	`+asserttype(twinx)isAxes`
	`7560`	`+twiny=ax.twiny()`
	`7561`	`+asserttype(twiny)isAxes`
`7556`	`7562`
`7557`	`7563`
`7558`	`7564`	`deftest_zero_linewidth():`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitecb384e

File tree

2 files changed

2 files changed

`‎lib/matplotlib/axes/_base.py`

`‎lib/matplotlib/tests/test_axes.py`

0 commit comments