Commitdffc19c

authored

Merge pull request#18172 from ianhi/report-button-correctly

allow webAgg to report middle click events

2 parents852c08e +ce8d715 commitdffc19cCopy full SHA for dffc19c

File tree

-8

lines changed

-8

lines changed

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,6 @@`
	`1`	`+webAgg backend no longer reports a middle click as a right click`
	`2`	`+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
	`3`	`+`
	`4`	`+Previously when using the webAgg backend the event passed to a callback`
	`5`	+by ``fig.canvas.mpl_connect('mouse_button_event', callback)`` on a middle click
	`6`	+would report `.MouseButton.RIGHT` instead of `.MouseButton.MIDDLE`

Lines changed: 0 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -260,14 +260,6 @@ def _handle_mouse(self, event):`
`260`	`260`	`# off by 1`
`261`	`261`	`button=event['button']+1`
`262`	`262`
`263`		`-# The right mouse button pops up a context menu, which`
`264`		`-# doesn't work very well, so use the middle mouse button`
`265`		`-# instead. It doesn't seem that it's possible to disable`
`266`		`-# the context menu in recent versions of Chrome. If this`
`267`		`-# is resolved, please also adjust the docstring in MouseEvent.`
`268`		`-ifbutton==2:`
`269`		`-button=3`
`270`		`-`
`271`	`263`	`e_type=event['type']`
`272`	`264`	`guiEvent=event.get('guiEvent',None)`
`273`	`265`	`ife_type=='button_press':`

Comments

(0)