NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

Commitc9464aa

committed

FIX: be more careful about not importing pyplot early

In matplotlib.use we import pyplot to use `switch_backend`, howeverif the user calls `mpl.use(...)` before importing pyplot thenduring the initial import of pyplot, before we set the selectedbackend we try to set the backend set via rcParams.This change only imports pyplot if it is already imported, otherwiseit is safe to just set the rcParams and not go through the full`plt.switch_backend` path.closes#17763

1 parent4a143b9 commitc9464aaCopy full SHA for c9464aa

File tree

1 file changed

+24

-6

lines changed

lib/matplotlib
- __init__.py

1 file changed

+24

-6

lines changed

`‎lib/matplotlib/init.py`

Lines changed: 24 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1136,16 +1136,34 @@ def use(backend, *, force=True):`
`1136`	`1136`	`matplotlib.get_backend`
`1137`	`1137`	`"""`
`1138`	`1138`	`name=validate_backend(backend)`
	`1139`	`+# we need to use the base-class method here to avoid (prematurely)`
	`1140`	`+# resolving the "auto" backend setting`
`1139`	`1141`	`ifdict.__getitem__(rcParams,'backend')==name:`
`1140`	`1142`	`# Nothing to do if the requested backend is already set`
`1141`	`1143`	`pass`
`1142`	`1144`	`else:`
`1143`		`-try:`
`1144`		`-frommatplotlibimportpyplotasplt`
`1145`		`-plt.switch_backend(name)`
`1146`		`-exceptImportError:`
`1147`		`-ifforce:`
`1148`		`-raise`
	`1145`	`+# if pyplot is not already imported, do not import it. Doing`
	`1146`	+# so may trigger a `plt.switch_backend` to the _default_ backend
	`1147`	`+# before we get a chance to change to the one the user just requested`
	`1148`	`+plt=sys.modules.get('matplotlib.pyplot')`
	`1149`	`+# if pyplot is imported, then try to change backends`
	`1150`	`+ifpltisnotNone:`
	`1151`	`+try:`
	`1152`	`+# we need this import check here to re-raise if the`
	`1153`	`+# user does not have the libraries to support their`
	`1154`	`+# chosen backend installed.`
	`1155`	`+plt.switch_backend(name)`
	`1156`	`+exceptImportError:`
	`1157`	`+ifforce:`
	`1158`	`+raise`
	`1159`	`+# if we have not imported pyplot, then we can set the rcParam`
	`1160`	`+# value which will be respected when the user finally imports`
	`1161`	`+# pyplot`
	`1162`	`+else:`
	`1163`	`+rcParams['backend']=backend`
	`1164`	`+# if the user has asked for a given backend, do not helpfully`
	`1165`	`+# fallback`
	`1166`	`+rcParams['backend_fallback']=False`
`1149`	`1167`
`1150`	`1168`
`1151`	`1169`	`ifos.environ.get('MPLBACKEND'):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commitc9464aa

File tree

1 file changed

1 file changed

`‎lib/matplotlib/init.py`

0 commit comments

Movatterモバイル変換

Uh oh!

File tree

1 file changed

1 file changed

‎lib/matplotlib/__init__.py

0 commit comments

`‎lib/matplotlib/init.py`