Commitc90234f

authored

Merge pull request#27785 from tacaswell/fix/windows_pgf_shutdown

FIX: be careful about communicating with subprocess

2 parents27c3dc9 +41bf7cc commitc90234fCopy full SHA for c90234f

File tree

-2

lines changed

-2

lines changed

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,8 @@ def _setup_latex_process(self, *, expect_reply=True):`
`257`	`257`	`# Open LaTeX process for real work; register it for deletion. On`
`258`	`258`	`# Windows, we must ensure that the subprocess has quit before being`
`259`	`259`	`# able to delete the tmpdir in which it runs; in order to do so, we`
`260`		-# must first `kill()` it, and then `communicate()` with it.
	`260`	+# must first `kill()` it, and then `communicate()` with or `wait()` on
	`261`	`+# it.`
`261`	`262`	`try:`
`262`	`263`	`self.latex=subprocess.Popen(`
`263`	`264`	`[mpl.rcParams["pgf.texsystem"],"-halt-on-error"],`
`@@ -274,7 +275,10 @@ def _setup_latex_process(self, *, expect_reply=True):`
`274`	`275`
`275`	`276`	`deffinalize_latex(latex):`
`276`	`277`	`latex.kill()`
`277`		`-latex.communicate()`
	`278`	`+try:`
	`279`	`+latex.communicate()`
	`280`	`+exceptRuntimeError:`
	`281`	`+latex.wait()`
`278`	`282`
`279`	`283`	`self._finalize_latex=weakref.finalize(`
`280`	`284`	`self,finalize_latex,self.latex)`

Comments

(0)