Commitc519536

authored

Merge pull request#24151 from meeseeksmachine/auto-backport-of-pr-24149-on-v3.6.x

Backport PR#24149 on branch v3.6.x (FIX: handle input to ax.bar that is all nan)

2 parents3d2bbe3 +e6dd37b commitc519536Copy full SHA for c519536

File tree

+21

-0

lines changed

+21

-0

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2182,11 +2182,19 @@ def _convert_dx(dx, x0, xconv, convert):`
`2182`	`2182`	`x0=cbook._safe_first_finite(x0)`
`2183`	`2183`	`except (TypeError,IndexError,KeyError):`
`2184`	`2184`	`pass`
	`2185`	`+exceptStopIteration:`
	`2186`	`+# this means we found no finite element, fall back to first`
	`2187`	`+# element unconditionally`
	`2188`	`+x0=cbook.safe_first_element(x0)`
`2185`	`2189`
`2186`	`2190`	`try:`
`2187`	`2191`	`x=cbook._safe_first_finite(xconv)`
`2188`	`2192`	`except (TypeError,IndexError,KeyError):`
`2189`	`2193`	`x=xconv`
	`2194`	`+exceptStopIteration:`
	`2195`	`+# this means we found no finite element, fall back to first`
	`2196`	`+# element unconditionally`
	`2197`	`+x=cbook.safe_first_element(xconv)`
`2190`	`2198`
`2191`	`2199`	`delist=False`
`2192`	`2200`	`ifnotnp.iterable(dx):`

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -8144,3 +8144,16 @@ def test_bar_leading_nan():`
`8144`	`8144`	`forbinrest:`
`8145`	`8145`	`assertnp.isfinite(b.xy).all()`
`8146`	`8146`	`assertnp.isfinite(b.get_width())`
	`8147`	`+`
	`8148`	`+`
	`8149`	`+@check_figures_equal(extensions=["png"])`
	`8150`	`+deftest_bar_all_nan(fig_test,fig_ref):`
	`8151`	`+mpl.style.use("mpl20")`
	`8152`	`+ax_test=fig_test.subplots()`
	`8153`	`+ax_ref=fig_ref.subplots()`
	`8154`	`+`
	`8155`	`+ax_test.bar([np.nan], [np.nan])`
	`8156`	`+ax_test.bar([1], [1])`
	`8157`	`+`
	`8158`	`+ax_ref.bar([1], [1]).remove()`
	`8159`	`+ax_ref.bar([1], [1])`

Comments

(0)