Commitb87772d

Nathan Goldbaum

committed

add test for movie writing floating point roundoff issues

1 parent81b072a commitb87772dCopy full SHA for b87772d

File tree

+16

-3

lines changed

+16

-3

lines changed

Lines changed: 1 addition & 0 deletions

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -288,8 +288,11 @@ def _adjust_frame_size(self):`
`288`	`288`	`verbose.report('figure size (inches) has been adjusted '`
`289`	`289`	`'from %s x %s to %s x %s'% (wo,ho,w,h),`
`290`	`290`	`level='helpful')`
	`291`	`+else:`
	`292`	`+w,h=self.fig.get_size_inches()`
`291`	`293`	`verbose.report('frame size in pixels is %s x %s'%self.frame_size,`
`292`	`294`	`level='debug')`
	`295`	`+returnw,h`
`293`	`296`
`294`	`297`	`defsetup(self,fig,outfile,dpi=None):`
`295`	`298`	`'''`
`@@ -311,7 +314,7 @@ def setup(self, fig, outfile, dpi=None):`
`311`	`314`	`ifdpiisNone:`
`312`	`315`	`dpi=self.fig.dpi`
`313`	`316`	`self.dpi=dpi`
`314`		`-self._adjust_frame_size()`
	`317`	`+self._w,self._h=self._adjust_frame_size()`
`315`	`318`
`316`	`319`	`# Run here so that grab_frame() can write the data to a pipe. This`
`317`	`320`	`# eliminates the need for temp files.`
`@@ -347,7 +350,7 @@ def grab_frame(self, **savefig_kwargs):`
`347`	`350`	`verbose.report('MovieWriter.grab_frame: Grabbing frame.',`
`348`	`351`	`level='debug')`
`349`	`352`	`try:`
`350`		`-self._adjust_frame_size()`
	`353`	`+self.fig.set_size_inches(self._w,self._h)`
`351`	`354`	`# Tell the figure to save its data to the sink, using the`
`352`	`355`	`# frame format and dpi.`
`353`	`356`	`self.fig.savefig(self._frame_sink(),format=self.frame_format,`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,14 @@ def test_save_animation_smoketest(tmpdir, writer, extension):`
`145`	`145`	`ax.set_xlim(0,10)`
`146`	`146`	`ax.set_ylim(-1,1)`
`147`	`147`
	`148`	`+dpi=None`
	`149`	`+codec=None`
	`150`	`+ifwriter=='ffmpeg':`
	`151`	`+# Issue #8253`
	`152`	`+fig.set_size_inches((10.85,9.2000000000000011))`
	`153`	`+dpi=100.`
	`154`	`+codec='h264'`
	`155`	`+`
`148`	`156`	`definit():`
`149`	`157`	`line.set_data([], [])`
`150`	`158`	`returnline,`
`@@ -160,7 +168,8 @@ def animate(i):`
`160`	`168`	`withtmpdir.as_cwd():`
`161`	`169`	`anim=animation.FuncAnimation(fig,animate,init_func=init,frames=5)`
`162`	`170`	`try:`
`163`		`-anim.save('movie.'+extension,fps=30,writer=writer,bitrate=500)`
	`171`	`+anim.save('movie.'+extension,fps=30,writer=writer,bitrate=500,`
	`172`	`+dpi=dpi,codec=codec)`
`164`	`173`	`exceptUnicodeDecodeError:`
`165`	`174`	`pytest.xfail("There can be errors in the numpy import stack, "`
`166`	`175`	`"see issues #1891 and #2679")`

Comments

(0)