Commita118261

committed

ENH: Update view limits on units change

This adds a independent callback for units changes that both updates thedata limits (relim) as well as the view limits (autoscale_view).

1 parent3b97e55 commita118261Copy full SHA for a118261

File tree

+12

-4

lines changed

+12

-4

lines changed

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -556,11 +556,11 @@ def __init__(self, fig, rect,`
`556`	`556`
`557`	`557`	`ifself.xaxisisnotNone:`
`558`	`558`	`self._xcid=self.xaxis.callbacks.connect('units finalize',`
`559`		`-self.relim)`
	`559`	`+self._on_units_changed)`
`560`	`560`
`561`	`561`	`ifself.yaxisisnotNone:`
`562`	`562`	`self._ycid=self.yaxis.callbacks.connect('units finalize',`
`563`		`-self.relim)`
	`563`	`+self._on_units_changed)`
`564`	`564`
`565`	`565`	`self.tick_params(`
`566`	`566`	`top=rcParams['xtick.top']andrcParams['xtick.minor.top'],`
`@@ -1890,6 +1890,15 @@ def add_container(self, container):`
`1890`	`1890`	`container.set_remove_method(lambdah:self.containers.remove(h))`
`1891`	`1891`	`returncontainer`
`1892`	`1892`
	`1893`	`+def_on_units_changed(self):`
	`1894`	`+"""`
	`1895`	`+ Callback for processing changes to axis units.`
	`1896`	`+`
	`1897`	`+ Currently forces updates of data limits and view limits.`
	`1898`	`+ """`
	`1899`	`+self.relim()`
	`1900`	`+self.autoscale_view()`
	`1901`	`+`
`1893`	`1902`	`defrelim(self,visible_only=False):`
`1894`	`1903`	`"""`
`1895`	`1904`	`Recompute the data limits based on current artists. If you want to`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,6 @@ def convert(value, unit, axis):`
`75`	`75`	`ax.axvline(Quantity(120,'minutes'),color='tab:green')`
`76`	`76`	`ax.yaxis.set_units('inches')`
`77`	`77`	`ax.xaxis.set_units('seconds')`
`78`		`-ax.autoscale_view()`
`79`	`78`
`80`	`79`	`assertqc.convert.called`
`81`	`80`	`assertqc.axisinfo.called`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ def __init__(self, fig, rect=None, args, *kwargs):`
`115`	`115`
`116`	`116`	`ifself.zaxisisnotNone :`
`117`	`117`	`self._zcid=self.zaxis.callbacks.connect('units finalize',`
`118`		`-self.relim)`
	`118`	`+self._on_units_changed)`
`119`	`119`	`else :`
`120`	`120`	`self._zcid=None`
`121`	`121`

Comments

(0)