Commit928e58c

committed

Error on bad input to hexbin extents

1 parentd3892d5 commit928e58cCopy full SHA for 928e58c

File tree

+16

-0

lines changed

+16

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4999,6 +4999,10 @@ def reduce_C_function(C: array) -> float`
`4999`	`4999`	`ty=np.log10(ty)`
`5000`	`5000`	`ifextentisnotNone:`
`5001`	`5001`	`xmin,xmax,ymin,ymax=extent`
	`5002`	`+ifxmin>xmax:`
	`5003`	`+raiseValueError("In extent, xmax must be greater than xmin")`
	`5004`	`+ifymin>ymax:`
	`5005`	`+raiseValueError("In extent, ymax must be greater than ymin")`
`5002`	`5006`	`else:`
`5003`	`5007`	`xmin,xmax= (tx.min(),tx.max())iflen(x)else (0,1)`
`5004`	`5008`	`ymin,ymax= (ty.min(),ty.max())iflen(y)else (0,1)`

Lines changed: 12 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -962,6 +962,18 @@ def test_hexbin_extent():`
`962`	`962`	`ax.hexbin("x","y",extent=[.1,.3,.6,.7],data=data)`
`963`	`963`
`964`	`964`
	`965`	`+deftest_hexbin_bad_extents():`
	`966`	`+fig,ax=plt.subplots()`
	`967`	`+data= (np.arange(2000)/2000).reshape((2,1000))`
	`968`	`+x,y=data`
	`969`	`+`
	`970`	`+withpytest.raises(ValueError,match="In extent, xmax must be greater than xmin"):`
	`971`	`+ax.hexbin(x,y,extent=(1,0,0,1))`
	`972`	`+`
	`973`	`+withpytest.raises(ValueError,match="In extent, ymax must be greater than ymin"):`
	`974`	`+ax.hexbin(x,y,extent=(0,1,1,0))`
	`975`	`+`
	`976`	`+`
`965`	`977`	`@image_comparison(['hexbin_empty.png'],remove_text=True)`
`966`	`978`	`deftest_hexbin_empty():`
`967`	`979`	`# From #3886: creating hexbin from empty dataset raises ValueError`

Comments

(0)