Commit8bdd0ca

committed

Emit "axes not compatible with tight_layout" in a single place.

... instead of triplicating it on the caller side.

1 parentf2b5486 commit8bdd0caCopy full SHA for 8bdd0ca

File tree

-24

lines changed

-24

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,10 @@ def get_tight_layout_figure(fig, axes_list, subplotspec_list, renderer,`
`226`	`226`	`ss_to_subplots= {ss: []forssinsubplotspec_list}`
`227`	`227`	`forax,ssinzip(axes_list,subplotspec_list):`
`228`	`228`	`ss_to_subplots[ss].append(ax)`
`229`		`-ss_to_subplots.pop(None,None)# Skip subplotspec == None.`
	`229`	`+ifss_to_subplots.pop(None,None):`
	`230`	`+_api.warn_external(`
	`231`	`+"This figure includes Axes that are not compatible with "`
	`232`	`+"tight_layout, so results might be incorrect.")`
`230`	`233`	`ifnotss_to_subplots:`
`231`	`234`	`return {}`
`232`	`235`	`subplot_list=list(ss_to_subplots.values())`

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -3424,12 +3424,6 @@ def tight_layout(self, *, pad=1.08, h_pad=None, w_pad=None, rect=None):`
`3424`	`3424`	`.Figure.set_layout_engine`
`3425`	`3425`	`.pyplot.tight_layout`
`3426`	`3426`	`"""`
`3427`		`-from ._tight_layoutimportget_subplotspec_list`
`3428`		`-subplotspec_list=get_subplotspec_list(self.axes)`
`3429`		`-ifNoneinsubplotspec_list:`
`3430`		`-_api.warn_external("This figure includes Axes that are not "`
`3431`		`-"compatible with tight_layout, so results "`
`3432`		`-"might be incorrect.")`
`3433`	`3427`	`# note that here we do not permanently set the figures engine to`
`3434`	`3428`	`# tight_layout but rather just perform the layout in place and remove`
`3435`	`3429`	`# any previous engines.`

Lines changed: 3 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -467,19 +467,12 @@ def tight_layout(self, figure, renderer=None,`
`467`	`467`	`coordinates that the whole subplots area (including labels) will`
`468`	`468`	`fit into. Default (None) is the whole figure.`
`469`	`469`	`"""`
`470`		`-`
`471`		`-subplotspec_list=_tight_layout.get_subplotspec_list(`
`472`		`-figure.axes,grid_spec=self)`
`473`		`-ifNoneinsubplotspec_list:`
`474`		`-_api.warn_external("This figure includes Axes that are not "`
`475`		`-"compatible with tight_layout, so results "`
`476`		`-"might be incorrect.")`
`477`		`-`
	`470`	`+from ._tight_layoutimportget_subplotspec_list`
`478`	`471`	`ifrendererisNone:`
`479`	`472`	`renderer=figure._get_renderer()`
`480`		`-`
`481`	`473`	`kwargs=_tight_layout.get_tight_layout_figure(`
`482`		`-figure,figure.axes,subplotspec_list,renderer,`
	`474`	`+figure,figure.axes,`
	`475`	`+get_subplotspec_list(figure.axes,grid_spec=self),renderer,`
`483`	`476`	`pad=pad,h_pad=h_pad,w_pad=w_pad,rect=rect)`
`484`	`477`	`ifkwargs:`
`485`	`478`	`self.update(**kwargs)`

Lines changed: 1 addition & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`fromcontextlibimportnullcontext`
`18`	`18`
`19`	`19`	`importmatplotlibasmpl`
`20`		`-importmatplotlib._apias_api`
`21`	`20`
`22`	`21`	`frommatplotlib._constrained_layoutimportdo_constrained_layout`
`23`	`22`	`frommatplotlib._tight_layoutimport (get_subplotspec_list,`
`@@ -170,15 +169,10 @@ def execute(self, fig):`
`170`	`169`	See also: `.figure.Figure.tight_layout` and `.pyplot.tight_layout`.
`171`	`170`	`"""`
`172`	`171`	`info=self._params`
`173`		`-subplotspec_list=get_subplotspec_list(fig.axes)`
`174`		`-ifNoneinsubplotspec_list:`
`175`		`-_api.warn_external("This figure includes Axes that are not "`
`176`		`-"compatible with tight_layout, so results "`
`177`		`-"might be incorrect.")`
`178`	`172`	`renderer=fig._get_renderer()`
`179`	`173`	`withgetattr(renderer,"_draw_disabled",nullcontext)():`
`180`	`174`	`kwargs=get_tight_layout_figure(`
`181`		`-fig,fig.axes,subplotspec_list,renderer,`
	`175`	`+fig,fig.axes,get_subplotspec_list(fig.axes),renderer,`
`182`	`176`	`pad=info['pad'],h_pad=info['h_pad'],w_pad=info['w_pad'],`
`183`	`177`	`rect=info['rect'])`
`184`	`178`	`ifkwargs:`

Comments

(0)