NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22k

Commit86a86e2

committed

Fix cbook._reshape2D for scalar object inputs.

Before the fix, `plt.hist(None)` would fail with `x must have 2 or fewerdimensions`, which it does have. Now it fails with a bit later with`unsupported operands type(s) for +: 'NoneType' and 'float'`, which ishopefully clearer.

1 parent9a077e8 commit86a86e2Copy full SHA for 86a86e2

File tree

1 file changed

-1

lines changed

lib/matplotlib/cbook
- __init__.py

1 file changed

-1

lines changed

`‎lib/matplotlib/cbook/init.py‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1990,7 +1990,7 @@ def _reshape_2D(X, name):`
`1990`	`1990`	`name is used to generate the error message for invalid inputs.`
`1991`	`1991`	`"""`
`1992`	`1992`	`# Iterate over columns for ndarrays, over rows otherwise.`
`1993`		`-X=X.Tifisinstance(X,np.ndarray)elsenp.asarray(X)`
	`1993`	`+X=np.atleast_1d(X.Tifisinstance(X,np.ndarray)elsenp.asarray(X))`
`1994`	`1994`	`ifX.ndim==1andX.dtype.type!=np.object_:`
`1995`	`1995`	`# 1D array of scalars: directly return it.`
`1996`	`1996`	`return [X]`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit86a86e2

File tree

1 file changed

1 file changed

`‎lib/matplotlib/cbook/init.py‎`

0 commit comments

Movatterモバイル変換

Uh oh!

File tree

1 file changed

1 file changed

‎lib/matplotlib/cbook/__init__.py‎

0 commit comments

`‎lib/matplotlib/cbook/init.py‎`