Commit7eaac32

authored

Merge pull request#24657 from larsoner/savefig

BUG: Fix bug with mutable input modification

2 parentse883f43 +76e087d commit7eaac32Copy full SHA for 7eaac32

File tree

-0

lines changed

-0

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1653,6 +1653,9 @@ def imsave(fname, arr, vmin=None, vmax=None, cmap=None, format=None,`
`1653`	`1653`	`rgba=sm.to_rgba(arr,bytes=True)`
`1654`	`1654`	`ifpil_kwargsisNone:`
`1655`	`1655`	`pil_kwargs= {}`
	`1656`	`+else:`
	`1657`	`+# we modify this below, so make a copy (don't modify caller's dict)`
	`1658`	`+pil_kwargs=pil_kwargs.copy()`
`1656`	`1659`	`pil_shape= (rgba.shape[1],rgba.shape[0])`
`1657`	`1660`	`image=PIL.Image.frombuffer(`
`1658`	`1661`	`"RGBA",pil_shape,rgba,"raw","RGBA",0,1)`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -254,9 +254,11 @@ def test_pil_kwargs_webp():`
`254`	`254`	`buf_small=io.BytesIO()`
`255`	`255`	`pil_kwargs_low= {"quality":1}`
`256`	`256`	`plt.savefig(buf_small,format="webp",pil_kwargs=pil_kwargs_low)`
	`257`	`+assertlen(pil_kwargs_low)==1`
`257`	`258`	`buf_large=io.BytesIO()`
`258`	`259`	`pil_kwargs_high= {"quality":100}`
`259`	`260`	`plt.savefig(buf_large,format="webp",pil_kwargs=pil_kwargs_high)`
	`261`	`+assertlen(pil_kwargs_high)==1`
`260`	`262`	`assertbuf_large.getbuffer().nbytes>buf_small.getbuffer().nbytes`
`261`	`263`
`262`	`264`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,7 @@ def test_imsave_pil_kwargs_tiff():`
`249`	`249`	`buf=io.BytesIO()`
`250`	`250`	`pil_kwargs= {"description":"test image"}`
`251`	`251`	`plt.imsave(buf, [[0,1], [2,3]],format="tiff",pil_kwargs=pil_kwargs)`
	`252`	`+assertlen(pil_kwargs)==1`
`252`	`253`	`im=Image.open(buf)`
`253`	`254`	`tags= {TAGS[k].name:vfork,vinim.tag_v2.items()}`
`254`	`255`	`asserttags["ImageDescription"]=="test image"`

Comments

(0)