Commit73985d9

authored

Merge pull request#26544 from QuLogic/auto-backport-of-pr-26532-on-v3.7.x

Backport PR#26532: Fix input check in Poly3DCollection.__init__

2 parents2679b8e +4a1ef78 commit73985d9Copy full SHA for 73985d9

File tree

+11

-1

lines changed

+11

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ def __init__(self, verts, *args, zsort='average', shade=False,`
`880`	`880`	`kwargs['edgecolors']=_shade_colors(`
`881`	`881`	`edgecolors,normals,lightsource`
`882`	`882`	`)`
`883`		`-iffacecolorsisNoneandedgecolorsinNone:`
	`883`	`+iffacecolorsisNoneandedgecolorsisNone:`
`884`	`884`	`raiseValueError(`
`885`	`885`	`"You must provide facecolors, edgecolors, or both for "`
`886`	`886`	`"shade to work.")`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2176,3 +2176,13 @@ def test_mutating_input_arrays_y_and_z(fig_test, fig_ref):`
`2176`	`2176`	`y= [0.0,0.0,0.0]`
`2177`	`2177`	`z= [0.0,0.0,0.0]`
`2178`	`2178`	`ax2.plot(x,y,z,'o-')`
	`2179`	`+`
	`2180`	`+`
	`2181`	`+deftest_Poly3DCollection_init_value_error():`
	`2182`	`+# smoke test to ensure the input check works`
	`2183`	`+# GH#26420`
	`2184`	`+withpytest.raises(ValueError,`
	`2185`	`+match='You must provide facecolors, edgecolors, '`
	`2186`	`+'or both for shade to work.'):`
	`2187`	`+poly=np.array([[0,0,1], [0,1,1], [0,0,0]],float)`
	`2188`	`+c=art3d.Poly3DCollection([poly],shade=True)`

Comments

(0)